Closes #31. Add the ability to specify the view ACLs. Piggyback off of the MR config.#35
Merged
Merged
Conversation
…ck off of the MR config.
oliverhu
approved these changes
Apr 16, 2018
oliverhu
left a comment
oliverhu
left a comment
There was a problem hiding this comment.
The title is a bit misleading - Add the ability to specify the view ACLs, you're still not able to specify the ACLs in Dynamometer if you don't update cluster config for MRConfig.
Collaborator
|
the change LGTM. I am okay with title, so +1 from me. |
chliang71
approved these changes
Apr 17, 2018
Collaborator
Author
|
@oliverhu this config is defined on a job basis. You can specify it directly on the command line when launching the job, or on the configuration object used if launching the job programatically. No cluster config changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.